Log file path when image open throws exception #13144
Conversation
| try { | ||
| $this->_adapter->open($this->_fileName); | ||
| } catch (\Exception $e) { | ||
| throw new \Exception("{$e->getMessage()}: {$this->_fileName}"); |
There was a problem hiding this comment.
Why not add such information directly in adapter->open() method?
There was a problem hiding this comment.
So it doesn't need to be added to both existing adapters and any future adapters.
There was a problem hiding this comment.
It's a bit odd to catch exception and throw immediately to add information which was passed to adapter method anyway. Please move this addition to adapter(s) as it's clearly his responsibility to throw such exception.
As always, please do commit amend and force push.
There was a problem hiding this comment.
@orlangur ready for another look.
pmclain
force-pushed
the
feature/image-error
branch
from
98e8d03 to
47c497f
Compare
|
Hello, @pmclain! I am testing the changes that come with this PR and I was not able to reproduce the issue. Could you describe how to get the image that cause the error or just post it here in zip archive? I tried TIFF images and images that are corrupted with HEX-editor but with no success. Here is what I tried: |
|
@TomashKhamlai I'm attaching one of the corrupt images that have been giving me trouble. I wasn't able to upload this via the admin panel. I am primarily seeing this when running imports using external URIs for images, and I have been unable to reproduce reliably enough to determine if the download is failing or needing a more reliable validation mechanism. You may need to assign the product image attribute directly in the database or replace an existing image with a corrupt image, like the attached. |
Description
Log the offending file when opening an image throws an exception. The current exception message does a good job describing the problem, but does not tell you which file caused the issue. The proposed change would alter the log entry from:
Unsupported image format.to:
Unsupported image format.: /path/to/my/bad/file.pngFixed Issues (if relevant)
none
Manual testing scenarios
small_imageto a corrupt/unsupported image./var/reportto see the path to problem image.Contribution checklist